镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Use snprintf instead of sprintf - #5567

Merged
radarhere merged 2 commits into
python-pillow:masterfrom
radarhere:sprintf
Jul 1, 2021
Merged

radarhere merged 2 commits into
python-pillow:masterfrom
radarhere:sprintf

Conversation

@radarhere

Copy link
Copy Markdown
Member

Resolves

/* FIXME: may overflow if mode is too large */

and
/* FIXME: may overflow if mode is too large */

@wiredfool wiredfool left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to truncate the mode prior to passing to sprintf

@radarhere
radarhere requested a review from wiredfool June 30, 2021 13:54
@radarhere
radarhere merged commit 31c4738 into python-pillow:master Jul 1, 2021
@radarhere
radarhere deleted the sprintf branch July 1, 2021 02:58
@radarhere radarhere changed the title Limit sprintf modes to 10 characters Use snprintf instead of sprintf Jul 1, 2021
radarhere added a commit to radarhere/Pillow that referenced this pull request Jul 1, 2021
@radarhere

radarhere commented Jul 6, 2021 •

Copy link
Copy Markdown
Member Author

This is the fix for CVE-2021-34552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants